Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use palette and Color from top level Xilem and Masonry #800

Merged

Conversation

waywardmonkeys
Copy link
Contributor

No description provided.

@waywardmonkeys
Copy link
Contributor Author

This intentionally doesn't move anything around from the theme. That contains non-color data and wouldn't necessarily be appropriate here.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an improvement. Our re-exports are generally a mess, but masonry::vello::peniko::color::pallette is clearly obscene.

@@ -178,7 +178,7 @@ pub use cursor_icon::{CursorIcon, ParseError as CursorIconParseError};
pub use kurbo::{Affine, Insets, Point, Rect, Size, Vec2};
pub use parley::layout::Alignment as TextAlignment;
pub use parley::style::FontWeight;
pub use vello::peniko::{Color, Gradient};
pub use vello::peniko::{color::palette, Color, Gradient};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers, this is the new change to public API (it wasn't obvious to me on a first pass).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And a similar in xilem/src/lib.rs re-exporting from here (as it already did for Color).

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Dec 20, 2024
Merged via the queue into linebender:main with commit c1ef637 Dec 20, 2024
17 checks passed
@waywardmonkeys waywardmonkeys deleted the add-top-level-palette branch December 20, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants